Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

clean_duplicates() should remove *_files folder when .html files are removed #632

Closed
cderv opened this issue May 27, 2021 · 1 comment
Closed
Labels
bug an unexpected problem or unintended behavior feature a feature request or enhancement next to consider for next release

Comments

@cderv
Copy link
Collaborator

cderv commented May 27, 2021

While trying to test a workflow for my Hugo Apero workshop to help convert over an existing academic site, clean_duplicates() was used. Because of the choice I made with syntax highlighters, the testing implies converting over a site (where the posts have no need for pandoc) to full markdown mode.

.html are the duplicates in this case as the new post output will be .md so clean_duplicates() now correctly helps remove HTML file but their companion *_files folder still remain.

They should be removed too

_Originally posted by @apreshill in #629

@cderv cderv added feature a feature request or enhancement bug an unexpected problem or unintended behavior next to consider for next release and removed feature a feature request or enhancement labels May 27, 2021
@yihui yihui closed this as completed in f968374 Jul 21, 2021
@yihui
Copy link
Member

yihui commented Jul 21, 2021

The *_files directory cannot be deleted if it contains other subdirectories such as figure-html. For now, I'm only deleting the header-attrs subdirectory. After that, if the *_files directory becomes empty, I'll delete it, otherwise it won't be deleted. I think this should solve the original problem. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug an unexpected problem or unintended behavior feature a feature request or enhancement next to consider for next release
Projects
None yet
Development

No branches or pull requests

2 participants