Skip to content

Support GeoParquet #249

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
nathanjmcdougall opened this issue Jul 18, 2024 · 2 comments · May be fixed by #254
Open

Support GeoParquet #249

nathanjmcdougall opened this issue Jul 18, 2024 · 2 comments · May be fixed by #254
Labels
.enhancement New feature or request

Comments

@nathanjmcdougall
Copy link
Contributor

I'd like to add support for geoparquet, via geopandas.to_parquet and geopandas.read_parquet. Would a PR be welcome?

@isabelizimm isabelizimm added the .enhancement New feature or request label Jul 18, 2024
@isabelizimm
Copy link
Collaborator

isabelizimm commented Jul 19, 2024

That would definitely be welcome! I'm not sure exactly what you were envisioning, but I think it makes the most sense to have a geoparquet as a distinct type, separate from parquet.

In case they are useful places to start, on the pin_read side, boards use the load_data function to bring in the data. And then when pin_write is called, it is the save_data function that does the actual handling depending on data type.

@nathanjmcdougall
Copy link
Contributor Author

Definitely makes sense to add as a distinct type.

Given that all GeoParquet files use the same file extension .parquet and are valid Parquet files in their own right (it is a sub-specification), there could be some argument that using "parquet" with pin_write should automatically detect that the object is a GeoDataFrame and so use gpd.to_parquet instead of pd.to_parquet. But this is really just for convenience and could be added later. For now, I'll just focus on adding it as a distinct type.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
.enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants