Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

renv::dependencies() has become slow in release 1.0.8 #1999

Closed
HenningLorenzen-ext-bayer opened this issue Sep 27, 2024 · 4 comments
Closed

Comments

@HenningLorenzen-ext-bayer
Copy link
Contributor

With 1.0.8, renv::dependencies() takes 15-20 seconds to run. On the same project with 1.0.7, it used to be 2-3 seconds.

@kevinushey
Copy link
Collaborator

Thanks for the bug report; I was able to reproduce. I'll take a look.

@kevinushey
Copy link
Collaborator

I've made a number of optimizations to the implementation of renv::dependencies() in 16c05d5; any chance you could give it a download and let me know how things look? You can use e.g. renv::install("rstudio/renv") to install the development version of renv for testing.

@HenningLorenzen-ext-bayer
Copy link
Contributor Author

I've made a number of optimizations to the implementation of renv::dependencies() in 16c05d5; any chance you could give it a download and let me know how things look? You can use e.g. renv::install("rstudio/renv") to install the development version of renv for testing.

Great work! The optimized version not only beats v1.0.9 but also v1.0.7. 💪

Setup 1 Setup 2
1.0.7 2.8s 4.6s
1.0.9 7.5s 23.4s
16c05d5 1.9s 3.0s

@kevinushey
Copy link
Collaborator

Awesome news :-) Thanks for reporting back!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants