Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Is priority 900 in directive necessary? #1

Closed
waldenraines opened this issue Sep 23, 2013 · 3 comments
Closed

Is priority 900 in directive necessary? #1

waldenraines opened this issue Sep 23, 2013 · 3 comments

Comments

@waldenraines
Copy link

I am having some problems with the 900 priority here: https://github.com/rubenv/angular-gettext/blob/master/src/directive.js#L4 and my other directives so I'm wondering if it is necessary. Everything seems to work fine if I remove it.

@rubenv
Copy link
Owner

rubenv commented Sep 24, 2013

Yes, it breaks the E2E test if you comment it out.

PhantomJS 1.9.1 (Mac OS X) Click Should not break ng-click FAILED
        expect element '#field' text toBe "Success"
        expected "Success" but was ""
PhantomJS 1.9.1 (Mac OS X) Click Should not break ng-click for translated strings FAILED
        expect element '#field' text toBe "Success"
        expected "Success" but was ""
PhantomJS 1.9.1 (Mac OS X): Executed 2 of 2 (2 FAILED) ERROR (0.318 secs / 0.234 secs)

I'm not entirely happy with the way the transclusion is currently handled, but it does work for my test cases.

Do you have a test case to demonstrate the problem you're seeing? Would be nice to have it in the test suite.

@waldenraines
Copy link
Author

The problem between directives was actually on my end so no test case, sorry for the false alarm.

I'll leave it up to you whether to close this issue or leave it open.

@rubenv
Copy link
Owner

rubenv commented Sep 24, 2013

It needs a high priority so that it registers before ngClick, unless there's a good other way to do this, we'll need it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants