Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix an error for Performance/RedundantMerge #74

Merged
merged 1 commit into from
Jul 31, 2019

Conversation

koic
Copy link
Member

@koic koic commented Jul 30, 2019

Follow up #68 (comment).

#68 didn't solve an issue #67 with Performance/RedundantMerge.
This PR is corrected by adding a reproduction test.

Thanks @ashmaroli!


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Follow up rubocop#68 (comment).

rubocop#68 didn't solve an issue rubocop#67 with `Performance/RedundantMerge`.
This PR is corrected by adding a reproduction test.
@koic koic force-pushed the fix_error_for_redundant_merge branch from 519cfeb to 06f9333 Compare July 30, 2019 09:23
@koic koic merged commit 72b3a91 into rubocop:master Jul 31, 2019
@koic koic deleted the fix_error_for_redundant_merge branch July 31, 2019 02:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants