Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve the Performance/StringInclude cop #395

Closed
ydakuka opened this issue Nov 25, 2023 · 0 comments · Fixed by #400
Closed

Improve the Performance/StringInclude cop #395

ydakuka opened this issue Nov 25, 2023 · 0 comments · Fixed by #400

Comments

@ydakuka
Copy link
Contributor

ydakuka commented Nov 25, 2023

https://github.com/fastruby/fast-ruby#regexp-vs-regexpmatch-vs-regexpmatch-vs-stringmatch-vs-string-vs-stringmatch-code-

Describe the solution you'd like

# bad
def my_method
  /boo/ === 'foo'
end

# good
def my_method
  'foo'.include?('boo')
end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.57.2 (using Parser 3.2.2.4, rubocop-ast 1.29.0, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.19.0
  - rubocop-factory_bot 2.24.0
  - rubocop-performance 1.19.1
  - rubocop-rails 2.22.0
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.25.0
  - rubocop-thread_safety 0.5.1
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant