Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Invalid URI encoding with CGI.escape() #28

Closed
dumbbell opened this issue Feb 1, 2017 · 1 comment
Closed

Invalid URI encoding with CGI.escape() #28

dumbbell opened this issue Feb 1, 2017 · 1 comment
Assignees

Comments

@dumbbell
Copy link

dumbbell commented Feb 1, 2017

The client uses CGI.escape() to escape path segments in the created URLs. Unfortunately, this module produces invalid path segments: it transforms spaces to +. This is fine for query string, but not path segments.

Newer versions of Cowboy, which have a stricter URL parsing, leave the + characters alone. So when a user of this HTTP client wants to create eg. a vhost with a space in it, he ends up with a vhost with a +.

@michaelklishin michaelklishin self-assigned this Feb 1, 2017
@dumbbell
Copy link
Author

dumbbell commented Feb 2, 2017

Thank you very much for the fast patch! I confirm the testsuite is now successful when Cowboy 1.1.0 is used.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants