Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a memory usage check #2442

Open
dblock opened this issue May 20, 2024 · 0 comments
Open

Add a memory usage check #2442

dblock opened this issue May 20, 2024 · 0 comments
Labels

Comments

@dblock
Copy link
Member

dblock commented May 20, 2024

Coming from #2440 and #2441 and similar leaks that we've had in the past, add a tool that compares memory usage before/after a change in pull requests. This could be modeled after https://code.dblock.org/2024/04/19/commenting-on-pull-requests-in-github-actions.html (newer version in opensearch-project/opensearch-api-specification#297).

  1. Create a benchmark that causes a lot of memory allocations quickly.
  2. In every PR run the benchmark on the before code and the after code, generate some data on allocations.
  3. Add a comment to the PR showing the change.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant