Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add CI check to ensure that gemspec is up to date #152

Open
movermeyer opened this issue Jun 9, 2022 · 0 comments
Open

Add CI check to ensure that gemspec is up to date #152

movermeyer opened this issue Jun 9, 2022 · 0 comments

Comments

@movermeyer
Copy link
Collaborator

Problem

ruby-cldr.gemspec is auto-generated by bundle exec rake gemspec (via Jeweler).

However, developers will forget to run it as part of their PRs. Which means that we risk releasing a gem without all the required files, for example.

Potential solutions

a) add it to the checklist in the PR template
b) add a CI check that fails if bundle exec rake gemspec && rubocop -a ruby-cldr.gemspec produces any differences.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant