Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

gemspec: Exclude various YAML configuration files #217

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Aug 17, 2017

This PR makes the gemspec exclude 3 configuration files from the repository's root directory.

The problem that this change solves for me is that a Rake-task-based RuboCop
configuration-file finding method can run into these RuboCop rules, when they
are in a searched filesystem path.

(Another issue: The rules for this project currently present warnings when run with RuboCop 0.49.1.)

The warnings:

/Users/olle/opensource/rake/.rubocop.yml: Style/LineLength has the wrong namespace - should be Metrics
/Users/olle/opensource/rake/.rubocop.yml: Style/IndentationWidth has the wrong namespace - should be Layout
/Users/olle/opensource/rake/.rubocop.yml: Style/Tab has the wrong namespace - should be Layout
/Users/olle/opensource/rake/.rubocop.yml: Style/EmptyLines has the wrong namespace - should be Layout
/Users/olle/opensource/rake/.rubocop.yml: Style/TrailingBlankLines has the wrong namespace - should be Layout
/Users/olle/opensource/rake/.rubocop.yml: Style/TrailingWhitespace has the wrong namespace - should be Layout
/Users/olle/opensource/rake/.rubocop.yml: Style/SpaceBeforeBlockBraces has the wrong namespace - should be Layout
/Users/olle/opensource/rake/.rubocop.yml: Style/SpaceInsideBlockBraces has the wrong namespace - should be Layout
/Users/olle/opensource/rake/.rubocop.yml: Style/SpaceInsideHashLiteralBraces has the wrong namespace - should be Layout
/Users/olle/opensource/rake/.rubocop.yml: Style/CaseIndentation has the wrong namespace - should be Layout
Error: obsolete parameter AlignWith (for Lint/EndAlignment) found in /Users/olle/opensource/rake/.rubocop.yml
`AlignWith` has been renamed to `EnforcedStyleAlignWith`

@hsbt
Copy link
Member

hsbt commented Aug 18, 2017

Thanks to your suggestion and notice rubocop warnings. I will fix it warnings.

@olleolleolle olleolleolle deleted the fix/exclude-rubocop-yml-from-gemspec branch August 18, 2017 11:24
@hsbt hsbt mentioned this pull request Aug 21, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants