Improve multitask performance #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hsbt is there anything more that this PR needs to be merged? |
|
Interesting! @hsbt anything blocking us from merging this? |
hsbt
reviewed
Nov 5, 2018
| @@ -248,7 +248,7 @@ def invoke_prerequisites_concurrently(task_args, invocation_chain)# :nodoc: | |||
| r.invoke_with_call_chain(prereq_args, invocation_chain) | |||
| end | |||
| end | |||
| futures.each(&:value) | |||
| futures.reverse_each(&:value) | |||
2 similar comments
|
@jsm Thanks! |
This was referenced Mar 7, 2021
Merged
This was referenced Mar 15, 2021
Bump rake from 12.3.1 to 12.3.3 in /Ruby-Cucumber-Watir
saucelabs/extended-debugging-Ruby-examples#8
Open
This was referenced Mar 16, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread context switches are expensive, iterating through promises in reverse minimizes them.
See my blog post about it here: https://medium.com/@sanmiguelje/optimizing-rake-multitask-fece36a16c8f