Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rewrite Win32API class to Fiddle #494

Open
hsbt opened this issue Jan 4, 2023 · 1 comment
Open

Rewrite Win32API class to Fiddle #494

hsbt opened this issue Jan 4, 2023 · 1 comment
Labels
Windows

Comments

@hsbt
Copy link
Member

hsbt commented Jan 4, 2023 •
edited
Loading

There is no reason we use Win32API.rb instead of Fiddle directly.

https://github.com/ruby/reline/blob/master/lib/reline/windows.rb#L55
@headius
Copy link
Contributor

headius commented Jan 4, 2023 •
edited
Loading

I mentioned this in a related issue (#484) and I support moving away from using the stdlib Win32API. The main complication is that the copy/paste code in windows.rb for non-JRuby uses fiddle, which is a little bit broken on JRuby.

The code may be close to working, but I have not attempted it and I do not have a Windows machine on which to test currently.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Windows
Milestone
No milestone
Development

No branches or pull requests
3 participants
@headius @hsbt @ima1zumi