Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Heroku Compatibility #84

Open
jamesy829 opened this issue Jul 30, 2014 · 5 comments
Open

Heroku Compatibility #84

jamesy829 opened this issue Jul 30, 2014 · 5 comments
Assignees

Comments

@jamesy829
Copy link

I use the suggested guide to setup usage of env variables on Heroku

https://github.com/railsconfig/rails_config#working-with-heroku

I have my env variables on Heroku as following:

Settings.database.dbname: value
Settings.keys.aws_access_key_id: value
Settings.keys.aws_secret_access_key: value
Settings.keys.devise_secret_key: value
Settings.keys.directory: value
Settings.keys.region: value
Settings.keys.secret_key_base: value

I noticed that when it tries to run rake task, it would complain env variables not found, and doing some digging, I discovered those are not valid env variables and Rails would not pick them up properly.

I have pushed those env variables using the rake task provided bundle exec rake rails_config:heroku

Is this a valid bug or the expected behaviour? If its not a bug, what's the approach I should be taking.

Thanks in advance.

@jamesy829
Copy link
Author

Found a possible work around

https://github.com/finnlabs/rails_config-env_source

Giving it a shot and if works, submit a PR to merge

@jamesy829
Copy link
Author

I have confirmed using this and the specified format of environment variables will allow the deployment to Heroku work properly, would be nice to have this as part of this gem

@fredwu
Copy link
Member

fredwu commented Aug 6, 2015

Great work! Any chance of submitting a PR? :)

@pkuczynski pkuczynski added this to the 1.3 milestone May 12, 2016
@pkuczynski pkuczynski added the bug label May 12, 2016
@pkuczynski pkuczynski modified the milestones: 1.4, 1.6.0 Oct 23, 2017
@pkuczynski pkuczynski modified the milestones: 1.6.0, 1.6.1, 1.6.2 Nov 3, 2017
@pkuczynski pkuczynski modified the milestones: 1.7.0, 1.7.1 Feb 9, 2018
@pkuczynski pkuczynski removed this from the 1.7.1 milestone Jun 19, 2019
@pkuczynski
Copy link
Member

@cjlarose do you think it makes sense to add any of this to our source code?

@cjlarose
Copy link
Member

cjlarose commented Dec 9, 2020

I'll take a look. It's an old issue, so this might already be fixed, but we can at least improve our docs with recommendations.

@cjlarose cjlarose self-assigned this Dec 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Development

No branches or pull requests

4 participants