Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Unskip and improve specs marked as flaky in system/volunteers/index_spec #5798

Merged
merged 3 commits into from
Jun 1, 2024
Merged

Unskip and improve specs marked as flaky in system/volunteers/index_spec #5798

merged 3 commits into from
Jun 1, 2024

Conversation

solebared
Copy link
Collaborator

@solebared solebared commented May 31, 2024 •
edited
Loading

What github issue is this PR for, if any?

Hopefully fixes #5727

What changed, and why?

  1. Uncommented and unskipped a bunch of examples in spec/system/volunteers/index_spec.rb

  2. Eliminated all wait:s to try to recreate flakes in CI, but didn't run into any.

  3. Converted a bunch of find-then-assert occurrences to use corresponding capybara matchers instead. Eg:

    -  expect(page.all("table#volunteers tbody tr").count).to eq inactive_volunteers.count
+  expect(page).to have_selector("table#volunteers tbody tr", count: inactive_volunteers.count)Logo']")

  4. Hoping we can merge this in and see if we run into any flakiness over the weekend.

Feelings gif (optional)

will smith detective

@solebared
Uncomment specs to unearth flakes in CI
76e7378 
Note: also removed all forced `wait:`s.
@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels May 31, 2024
@solebared
Switch to using have_button matcher
a2467d4 
Likely more robust, though i didn't actually encounter any
flakiness here. Mostly just addressing the TODO comment.
@solebared
Grabbag of changes to mitigate possible flakiness
3f993ee 
Mostly converting find-then-check occurences to use capybara matchers
instead.
@github-actions github-actions bot added the erb label May 31, 2024
@solebared solebared marked this pull request as ready for review May 31, 2024 19:55
@solebared solebared changed the title WIP: investigating flaky specs in spec/system/volunteers/index_spec Unskip and improve specs marked as flaky spec/system/volunteers/index_spec May 31, 2024
@solebared solebared changed the title Unskip and improve specs marked as flaky spec/system/volunteers/index_spec Unskip and improve specs marked as flaky in system/volunteers/index_spec May 31, 2024
schoork
schoork approved these changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@schoork schoork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot woot!

@schoork schoork merged commit f139bcf into main Jun 1, 2024
20 checks passed
@schoork schoork deleted the solebared/xits/volunteers/index/5727 branch June 1, 2024 10:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@schoork schoork schoork approved these changes

@compwron compwron Awaiting requested review from compwron compwron is a code owner

@FireLemons FireLemons Awaiting requested review from FireLemons FireLemons is a code owner

@littleforest littleforest Awaiting requested review from littleforest

@elasticspoon elasticspoon Awaiting requested review from elasticspoon elasticspoon is a code owner

Assignees
No one assigned
Labels
erb ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

☂️ fix or remove xit-ignored tests
2 participants
@solebared @schoork