Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rucio dependencies in test environments should be installed the same way they are installed when Rucio is installed as a package #344

Open
rdimaio opened this issue Jul 25, 2024 · 1 comment
Assignees

Comments

@rdimaio
Copy link
Contributor

rdimaio commented Jul 25, 2024

Right now we first install dependencies via pip, then run the setup for the test environment, which also installs dependencies, but they've already been installed.
To better replicate an environment where the Rucio dependencies would be installed via the setup instructions, let's remove the pip dependency install step

@rdimaio rdimaio changed the title Install dependencies from the setup instructions, instead of manually installing them via pip beforehand Rucio dependencies in test environments should be installed the same way they are installed when Rucio is installed as a package Aug 2, 2024
@rdimaio
Copy link
Contributor Author

rdimaio commented Aug 2, 2024

Looked into this a bit more - from what I can tell we don't actually call setup instructions in our tests at all, we just install via pip. Normally this should be the same as the requirements that are installed when the rucio package is installed, but match_define_requirements (https://github.com/rucio/rucio/blob/dc0a90ce37b91ff044285603d29fa5bf8b604371/setuputil.py#L141) is what causes mismatches like rucio/rucio#6992

I think we should do this in our test environments:

  1. Remove match_define_requirements from the logic of dependency management
  2. Install Rucio in editable mode (https://stackoverflow.com/questions/35064426/when-would-the-e-editable-option-be-useful-with-pip-install) instead of installing from the requirements file

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant