Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

BUG : Excessive retrying #374

Open
andreasgangso opened this issue Aug 24, 2023 · 1 comment
Open

BUG : Excessive retrying #374

andreasgangso opened this issue Aug 24, 2023 · 1 comment
Assignees
Labels

Comments

@andreasgangso
Copy link

Describe the bug
I'm going to keep this short because @desusai7 already knows the details here.

But basically, RSCloudModeManager is only handing some specific response states, and is missing at least BAD_REQUEST. Should probably have an else {} to catch all edge cases.

else if (response.state == NETWORK_ERROR) {

This results in it retrying the same payload on every loop, which is like ~10 requests per second.

@andreasgangso
Copy link
Author

For the record, this was noticed through rudderlabs/rudder-sdk-flutter#116, where gzip payloads were sent to an old rudder-server without gzip support, which was causing the response to be 400 BAD_REQUEST.

@pallabmaiti pallabmaiti added the v1 label Sep 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants