getaddressifo is untested

[tcharding]

Something is wrong with the pubkeys field of the getaddressinfo method.

The Core v17 docs for it are

  "pubkeys"                     (string, optional) Array of pubkeys associated with the known redeemscript (only if "script" is "multisig")
    [
      "pubkey"
      ,...
    ]

And we have an Option<Vec<String>> type for the field. It was suggested that we may need #[serde(default)] but I tried that to no avail. I also wondered if the docs were wrong and tried Option<String>.

In intergration_test we have a test that is feature gated out with #[cfg(feature = "TODO")] (search for get_address_info).

[apoelstra]

serde(default) is about deserialization.

If you want to skip the field when serializing you can use #[serde(skip_serializing_if = "Option::is_none")].

[tcharding]

The bug, unless I'm mad, is with deserializing the data returned by core into the GetAddressInfo struct. The current code looks right, I guess I'm doing something brain dead someplace though.