You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Core RPC API is not consistent with the unit used for fee rates. I can't remember if it changes between versions or between methods but sometimes its BTC/kB and sometimes its satoshis per virtual byte. Fortunately these are different types (f64 and u64 respectively).
However, in the ecosystem, fee rates are also measured in sats per kilo weight unit. Both sats per vb and sats per kwu use u64 - we should make some effort to ensure that Core does not use both and that we are not mixing these up.
Perhaps #58 will help with this if we are checking values returned.
The text was updated successfully, but these errors were encountered:
The Core RPC API is not consistent with the unit used for fee rates. I can't remember if it changes between versions or between methods but sometimes its
BTC/kB
and sometimes itssatoshis per virtual byte
. Fortunately these are different types (f64 and u64 respectively).However, in the ecosystem, fee rates are also measured in sats per kilo weight unit. Both sats per vb and sats per kwu use
u64
- we should make some effort to ensure that Core does not use both and that we are not mixing these up.Perhaps #58 will help with this if we are checking values returned.
The text was updated successfully, but these errors were encountered: