Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fee rate units #60

Open
tcharding opened this issue Feb 12, 2025 · 0 comments
Open

Fee rate units #60

tcharding opened this issue Feb 12, 2025 · 0 comments

Comments

@tcharding
Copy link
Member

The Core RPC API is not consistent with the unit used for fee rates. I can't remember if it changes between versions or between methods but sometimes its BTC/kB and sometimes its satoshis per virtual byte. Fortunately these are different types (f64 and u64 respectively).

However, in the ecosystem, fee rates are also measured in sats per kilo weight unit. Both sats per vb and sats per kwu use u64 - we should make some effort to ensure that Core does not use both and that we are not mixing these up.

Perhaps #58 will help with this if we are checking values returned.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant