Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Discuss and sign off on error API #126

Open
tcharding opened this issue Nov 20, 2024 · 1 comment
Open

Discuss and sign off on error API #126

tcharding opened this issue Nov 20, 2024 · 1 comment
Labels
1.0 Issues and PRs required or helping to stabilize the API

Comments

@tcharding
Copy link
Member

tcharding commented Nov 20, 2024

Fix error APIs

ref: #43 (comment)

@Kixunil is not around at the moment and I do not know what is meant by this comment of his.

We want to 1.0 this crate, we should discuss and sign off on the error API.

Discussion should include:

IIRC, fully closing all the errors in this crate makes us have to duplicate the error types in rust-bitcoin. I did this at some stage in the past and it was a massive PITA. IMO we should just make a decision here and accept that we are stuck with it for 1.0

@tcharding tcharding added the 1.0 Issues and PRs required or helping to stabilize the API label Nov 20, 2024
@tcharding
Copy link
Member Author

In contradiction to the opinion I wrote here I hid the errors to see how it would look. See #129

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
1.0 Issues and PRs required or helping to stabilize the API
Projects
None yet
Development

No branches or pull requests

1 participant