Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ignore missing registers #67

Closed
burrbull opened this issue Jul 25, 2021 · 1 comment · Fixed by #176
Closed

Ignore missing registers #67

burrbull opened this issue Jul 25, 2021 · 1 comment · Fixed by #176

Comments

@burrbull
Copy link
Member

My question is about this check:
https://github.com/stm32-rs/svdtools/blob/d8521cd0dc0314365097edcac75ccbb1fa19864c/svdtools/patch.py#L1037-L1038

Is it necessary those checks to be hard error?
It is often particular chips don't have some registers. And we need to create individual rule for them which complicates all patch system.
I'd prefer this check be just warning saying "Rule ignored: register not found". Or something like this.

@adamgreig
Copy link
Member

Yea, maybe we could have a "-v" verbose mode that prints those errors, and otherwise they are silently ignored. For example we don't have any error at the moment if you try to delete something that doesn't exist, so it's not like we're consistent here anyway.

Having the verbose mode helps when trying to find out why your patch is not working, but we probably don't need the warning the rest of the time.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants