Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

default instrumentation flag, -Cllvm-args=-sanitizer-coverage-trace-compares, seems to add needless overhead #395

Open
0xalpharush opened this issue Feb 6, 2025 · 1 comment

Comments

@0xalpharush
Copy link
Contributor

Is there any value in using trace-cmp without -use_value_profile=1? I ask bc cargo fuzz seems to add this instrumentation by default but libfuzzer's value profile is disabled by default. IIUC but this should be mutually enabled or disabled.

If my understanding is correct, would a PR be accepted to disable this by default?

@nagisa
Copy link
Member

nagisa commented Feb 7, 2025

There is definitely a lot of improvement that's possible to how fuzz targets are built and run. Most of what we have today is very close to what we figured out on day 1 and the fuzzing ecosystem has had a lot of time to change since.

It would be interesting to see actual examples of how coverage changes without either flag, with just the instrumentation & with both options enabled, though.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants