Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Renderer::line_no is a confusing name #175

Open
epage opened this issue Jan 9, 2025 · 0 comments
Open

Renderer::line_no is a confusing name #175

epage opened this issue Jan 9, 2025 · 0 comments
Labels
C-bug Category: bug M-breaking-change Meta: Implementing or merging this will introduce a breaking change

Comments

@epage
Copy link
Contributor

epage commented Jan 9, 2025

What is no, nomber?

Is line_num / line_number the best name? I feel like this is the gutter style but its also used for .... Unsure what to call that.

We should probably change this to something else. If we want, we can smooth out the upgrade path by offering the name in a current version, deprecating the old name, and then removing the old name in a new version.

@epage epage added C-bug Category: bug M-breaking-change Meta: Implementing or merging this will introduce a breaking change labels Jan 9, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-bug Category: bug M-breaking-change Meta: Implementing or merging this will introduce a breaking change
Projects
None yet
Development

No branches or pull requests

1 participant