Skip to content

Depends on backtrace-sys even when rustc-dep-of-std is the only feature #253

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
RalfJung opened this issue Sep 16, 2019 · 0 comments · Fixed by #297
Closed

Depends on backtrace-sys even when rustc-dep-of-std is the only feature #253

RalfJung opened this issue Sep 16, 2019 · 0 comments · Fixed by #297

Comments

@RalfJung
Copy link
Member

When disabling all features except for rustc-dep-of-std, this crate should have minimal dependencies and, in particular, it would be great if it could build without a C toolchain for the target. That is needed to keep libstd (with no features) buildable without a C toolchain (modulo rust-lang/rust#56443).

However, currently, backtrace-sys is always built when building libstd, even with no features. The reason for this is probably that rustc-dep-of-std enables backtrace-sys/rustc-dep-of-std, which unfortunately implicitly enables backtrace-sys.

@alexcrichton suggests to work around this by making backtrace-sys with no features do basically nothing, and then enabling the "actually-build" feature only from backtrace's "libbacktrace" feature.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant