-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Rename the benches/
directory to benchmark/
or benchmarks/
#2725
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Or at least give us the option to configure it in Cargo.toml! 😄 |
@sunjay you should be able to list out benchmarks via |
I mean it would be nice if it were possible to specify something like: # section and field names are just examples, not necessarily what the actual names would be
[bench]
location = "benchmarks" You're right that you can already do this on a case by case basis, but it would be nice to just be able to modify the search path so all the awesome auto discovery features of cargo still work. |
Ah yes that's what I figured, and makes sense to me. |
As any target, |
Considering the command is I'd also be concerned about different packages changing this for little benefit, making it harder to jump from project to project. As for migrating the ecosystem from one to another, I don't see it paying off enough benefit with the name I'm proposing to the cargo team that we close this. |
Also, I feel like there was a similar issue for making the |
This could possibly be generalized to “being able to set the path of target auto-discovery”, though I agree it's more beneficial to have a community-wide project layout convention. Closing this. Let us know if there is something not working well without this feature. |
Found the related issue: #12672 |
Rational
benches
is ambiguous and may confuse English-as-Second-Language (ESL) programmers.benches
is only 3 letters shorter thanbenchmarks
, so it's not significantly shorter.benchmark
(singular) is only 2 letters longer thanbenches
.The text was updated successfully, but these errors were encountered: