cargo package: please provide a --list0 option to print NUL-terminated filenames

[joshtriplett]

cargo package --list lists all the filenames the .crate file would include, followed by newlines. A crate could potentially include a file whose name includes a newline, such as for test data. Please consider providing a cargo package --list0 option to list filenames followed by NUL characters instead of newlines.

(After adding such an option, cargo package --list should probably fail with an error and no other output if any filename includes a newline, to catch errors.)

[alexcrichton]

Sounds plausible to me!

[tbu-]

Or we could disallow these characters. I haven't seen legitimate use cases for file names with newlines in them, @joshtriplett do you know any?

[joshtriplett]

On November 21, 2016 2:59:03 PM PST, tbu- notifications@github.com wrote:

Or we could disallow these characters. I haven't seen legitimate use
cases for file names with newlines in them, @joshtriplett do you know
any?

Test cases; no other legitimate use that I can think of.

[weihanglo]

What should Cargo do for packaging a multi-package workspace for this list mode? Can JSON output (#11666) cover the use case of this?

[epage]

FYI the issue for cargo package --workspace --list is #13953.

[weihanglo]

We have a more solid solution now, a JSON output format for --list #15353, which also takes workspace into account. Unless there is a reason to have a new output format like nul-terminated, I propose to the team to close this in favor of #15353.

[epage]

I second. While json formatting isn't always the easiest for shell scripts to interact with, it is the primary focus of our programmatic interface and we'd be very limited in what a nul-terminated could represent.