publish: Change "unknown categories" warning to error

Author: Turbo87

src/controllers/krate/publish.rs

@@ -384,7 +384,12 @@ pub async fn publish(app: AppState, req: BytesRequest) -> AppResult<Json<GoodCra
 
             // Update all categories for this crate, collecting any invalid categories
             // in order to be able to warn about them
-            let ignored_invalid_categories = Category::update_crate(conn, &krate, &categories)?;
+            let unknown_categories = Category::update_crate(conn, &krate, &categories)?;
+            if !unknown_categories.is_empty() {
+                let unknown_categories = unknown_categories.join(", ");
+                let domain = &app.config.domain_name;
+                return Err(bad_request(format!("The following category slugs are not currently supported on crates.io: {}\n\nSee https://{}/category_slugs for a list of supported slugs.", unknown_categories, domain)));
+            }
 
             let top_versions = krate.top_versions(conn)?;
 
@@ -435,7 +440,7 @@ pub async fn publish(app: AppState, req: BytesRequest) -> AppResult<Json<GoodCra
             // that is no longer needed. As such, crates.io currently does not return any `other`
             // warnings at this time, but if we need to, the field is available.
             let warnings = PublishWarnings {
-                invalid_categories: ignored_invalid_categories,
+                invalid_categories: vec![],
                 invalid_badges: vec![],
                 other: vec![],
             };

src/tests/krate/publish/categories.rs

@@ -3,7 +3,7 @@ use crate::new_category;
 use crate::util::{RequestHelper, TestApp};
 use googletest::prelude::*;
 use http::StatusCode;
-use insta::assert_json_snapshot;
+use insta::{assert_json_snapshot, assert_snapshot};
 
 #[tokio::test(flavor = "multi_thread")]
 async fn good_categories() {
@@ -30,11 +30,8 @@ async fn ignored_categories() {
 
     let crate_to_publish = PublishBuilder::new("foo_ignored_cat", "1.0.0").category("bar");
     let response = token.publish_crate(crate_to_publish).await;
-    assert_eq!(response.status(), StatusCode::OK);
-    assert_json_snapshot!(response.json(), {
-        ".crate.created_at" => "[datetime]",
-        ".crate.updated_at" => "[datetime]",
-    });
+    assert_eq!(response.status(), StatusCode::BAD_REQUEST);
+    assert_snapshot!(response.text(), @r#"{"errors":[{"detail":"The following category slugs are not currently supported on crates.io: bar\n\nSee https://crates.io/category_slugs for a list of supported slugs."}]}"#);
 }
 
 #[tokio::test(flavor = "multi_thread")]