Skip to content

Please trigger rebuilds for reverse dependencies of async-std built with nightly-2020-09-23 #1065

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jplatte opened this issue Sep 24, 2020 · 5 comments
Labels
A-admin Area: Administration of the production docs.rs server C-build-failure Category: This is a crate that failed to build

Comments

@jplatte
Copy link

jplatte commented Sep 24, 2020

These all failed with

[INFO] [stderr] error[E0046]: not all trait items implemented, missing: `as_flags`
[INFO] [stderr]    --> /opt/rustwide/cargo-home/registry/src/github.heygears.com-1ecc6299db9ec823/async-std-1.6.4/src/fs/open_options.rs:303:5
[INFO] [stderr]     |
[INFO] [stderr] 303 |     impl OpenOptionsExt for OpenOptions {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `as_flags` in implementation
[INFO] [stderr]     |
[INFO] [stderr]     = help: implement the missing item: `fn as_flags(&self) -> std::result::Result<i32, futures_io::Error> { todo!() }`

because of rust-lang/rust#77089 (see also async-rs/async-std#883).

@jyn514
Copy link
Member

jyn514 commented Sep 24, 2020

Do you have suggestions for finding a list of crates that depend on async-std and failed to build?

@jyn514 jyn514 added C-build-failure Category: This is a crate that failed to build A-admin Area: Administration of the production docs.rs server labels Sep 24, 2020
@jplatte
Copy link
Author

jplatte commented Sep 24, 2020

No, I don't know whether there's any existing tooling that would help. A few are mentioned in the async-std issue though and rust-s3 is also affected.

@jyn514
Copy link
Member

jyn514 commented Sep 24, 2020

For posterity, the 465 crates in the queue were generated with

insert into queue (name, version) (
    select name, version from crates
        inner join releases on crates.id = releases.crate_id
        inner join builds on releases.id = builds.rid
    where not builds.build_status and rustc_version like '%2020-09-23%' or rustc_version like '%2020-09-22%'
);

@jyn514
Copy link
Member

jyn514 commented Sep 24, 2020

I double checked it contains at least redis_ts 0.2.0 so hopefully it got everything.

@jplatte
Copy link
Author

jplatte commented Sep 28, 2020

rust-s3 0.24.1 also has a working docs.rs page now. I think this is fixed.

@jplatte jplatte closed this as completed Sep 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-admin Area: Administration of the production docs.rs server C-build-failure Category: This is a crate that failed to build
Projects
None yet
Development

No branches or pull requests

2 participants