Skip to content

Move ready! macro to futures-core from futures-util #1698

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
taiki-e opened this issue Jun 30, 2019 · 0 comments · Fixed by #1699
Closed

Move ready! macro to futures-core from futures-util #1698

taiki-e opened this issue Jun 30, 2019 · 0 comments · Fixed by #1699

Comments

@taiki-e
Copy link
Member

taiki-e commented Jun 30, 2019

I think this macro is stable enough, and I think it makes sense that it is in the futures-core (this macro only depend on core::task. Also some crates which doesn't depend on futures-util redefine this macro).

The concern was that Poll could be changed to not implement Try trait (rust-lang/rust#59725 (comment)), but this cannot happen as futures_api has already stabilized.

Refs:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant