Add get_each_mut methods on RawTable and HashMap
#239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-miller
force-pushed
the
get-each-mut
branch
4 times, most recently
from
46b0f64 to
14d53af
Compare
|
Okay, fixed the problems I could find on my own, so this should be ready for review. |
cole-miller
force-pushed
the
get-each-mut
branch
from
14d53af to
baca89a
Compare
Amanieu
reviewed
Feb 17, 2021
cole-miller
force-pushed
the
get-each-mut
branch
from
baca89a to
f8b4197
Compare
These methods enable looking up mutable references to several entries in a table or map at once. They make use of the min_const_generics feature, which is available without a feature gate on recent nightly — but not yet stable — rustc. Hence everything added here is behind `#[cfg(feature = "nightly")]`. This also removes an unnecessary `unsafe` annotation for `Bucket::as_ptr`.
cole-miller
force-pushed
the
get-each-mut
branch
from
f8b4197 to
afce097
Compare
|
@bors r+ |
|
📌 Commit afce097 has been approved by |
|
☀️ Test successful - checks-travis |
|
Thanks! |
6 tasks
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
get_each_mutonRawTableand new methodsget_each_mutandget_each_key_value_mutonHashTable. These methods enable looking up mutable references to several table or map entries at once. They take advantage of min_const_generics, which is available without a feature gate on recent nightly (but not stable) compilers. Hence everything is behind#[cfg(feature = "nightly")]for now.Closes #151 (cc @HeroicKatora).