Skip to content

Adding accept4(2) to NetBSD #1636

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Thomasdezeeuw opened this issue Jan 4, 2020 · 1 comment · Fixed by #1705
Closed

Adding accept4(2) to NetBSD #1636

Thomasdezeeuw opened this issue Jan 4, 2020 · 1 comment · Fixed by #1705

Comments

@Thomasdezeeuw
Copy link
Contributor

According to https://www.netbsd.org/changes/changes-8.0.html, NetBSD (x86_64-unknown-netbsd) has had the accept4(2) system call since February 2017. When the system call was added (#394, #546) it seems NetBSD 8.0 wasn't released yet (?).

I have two questions:

  • Its it old/stable enough to add? Or is this crate targeting NetBSD 7.0?
  • Can anyone with a NetBSD installation add the system call?

I would add it myself but I don't have a NetBSD installation so I would have no idea if I did it correctly, as NetBSD isn't run on the CI either (it seems).

Related: tokio-rs/mio#1213.
@krytarowski
Copy link

accept4(2) is not a system call, but a libc wrapper to paccept(2). Supporting <8.0 has little point here and it will go EOL in few months.

@tormol tormol mentioned this issue Mar 21, 2020
Merged
@Thomasdezeeuw Thomasdezeeuw mentioned this issue Mar 27, 2020
Closed
@de-vri-es de-vri-es mentioned this issue Oct 30, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add accept4() for NetBSD, Illumos and Solaris tormol/rust-libc
2 participants
@Thomasdezeeuw @krytarowski