Implement vpmaxq_u8 on aarch64 #4193
Open
+123
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Feb 16, 2025
RalfJung
added
the
S-waiting-on-author
bjorn3
force-pushed
the
arm64_vpmaxq_u8
branch
from
928a961 to
cc3a305
Compare
|
Turns out the memchr test failures were because I was accidentally doing signed rather than unsigned comparisons. All tests are passing now. |
bjorn3
added
S-waiting-on-review
|
Please add a test; you can use the x86 intrinsic tests as template. In particular there should be a Miri test directly checking the signed vs unsigned issue. |
RalfJung
reviewed
Feb 21, 2025
rustbot
added
S-waiting-on-author
|
Added tests. @rustbot ready |
rustbot
added
S-waiting-on-review
bjorn3
force-pushed
the
arm64_vpmaxq_u8
branch
from
d4dc18f to
7aa4a47
Compare
RalfJung
reviewed
Feb 21, 2025
| } | ||
|
|
||
| // Used to implement the vpmaxq_u8 function. | ||
| // Folding maximum of adjacent pairs. |
There was a problem hiding this comment.
Suggested change
| // Folding maximum of adjacent pairs. | |
| // Computes the maximum of adjacent pairs; the first half of the output is produced from the first | |
| // input, the second half of the output from the second input. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is documented in https://developer.arm.com/architectures/instruction-sets/intrinsics/#q=vpmaxq_u8
This makes all memchr tests suite pass when I remove
#[cfg(not(miri))]from tests.Fixes #4191