Skip to content

Our test suite ignores ICEs #685

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
RalfJung opened this issue Apr 11, 2019 · 2 comments · Fixed by #703
Closed

Our test suite ignores ICEs #685

RalfJung opened this issue Apr 11, 2019 · 2 comments · Fixed by #703
Labels
A-tests Area: affects our test suite or CI C-bug Category: This is a bug.

Comments

@RalfJung
Copy link
Member

RalfJung commented Apr 11, 2019 •
edited
Loading

Because of Manishearth/compiletest-rs#169, our compiletest suite ignores ICEs. That is quite worrying, hence I think it is worth tracking on our side until we have a fix landed here.

The cargo miri test still detects ICEs (and that's how I noticed), but that is not run in rustc, and anyway it has much smaller coverage.
@RalfJung RalfJung added C-bug Category: This is a bug. A-tests Area: affects our test suite or CI labels Apr 11, 2019
@RalfJung
Copy link
Member Author

Current status: waiting for Manishearth/compiletest-rs#172 to land.

@RalfJung RalfJung mentioned this issue Apr 16, 2019
Merged
@RalfJung
Copy link
Member Author

The compiletest PR landed. :) Now we're just waiting for a release.

@RalfJung RalfJung mentioned this issue Apr 19, 2019
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-tests Area: affects our test suite or CI C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump compiletest RalfJung/miri
1 participant
@RalfJung