-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Unable to correctly identify a type of Windows static library name, such as foo.lib
#146
Comments
Unfortunately it's not that easy. To know whether it's one or another you actually need to parse the file. |
Yes, there's no simple way to automatically tell a If I call, Another solution is to add a special option to
|
Hmm... on Windows both static |
Hmm..., I mean, for a static library named |
Right but if we look at the code that uses it, there doesn't seem to much difference: Lines 718 to 726 in d039d32
The only difference between the two branches is |
For a static library, if it runs to the branch |
I'm confused as to why that would be as rustc treats them the same way (see here and here): fn link_dylib(&mut self, lib: &str, verbatim: bool, _as_needed: bool) {
self.cmd.arg(format!("{}{}", lib, if verbatim { "" } else { ".lib" }));
}
fn link_staticlib(&mut self, lib: &str, verbatim: bool) {
self.cmd.arg(format!("{}{}", lib, if verbatim { "" } else { ".lib" }));
} I think it would help to have a minimal example to test this. It could be a problem in rust or cargo itself. |
I have made a patch to fix it.
The text was updated successfully, but these errors were encountered: