Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Model the query dependency graph #19042

Open
Veykril opened this issue Jan 27, 2025 · 0 comments
Open

Model the query dependency graph #19042

Veykril opened this issue Jan 27, 2025 · 0 comments
Labels
A-documentation docs for rust-analyzer usage/inner working A-salsa might be a salsa issue Broken Window Bugs / technical debt to be addressed immediately

Comments

@Veykril
Copy link
Member

Veykril commented Jan 27, 2025

(to be done after the salsa migration)
No one really has a clear picture on our queries, their individual purposes, their dependencies, etc. Given we are going to touch all of this with the salsa migration over time we might as well try to document all of this properly (and maybe generate a fancy visual dependency graph while we are at it).

What's the use in this? The dependencies we draw between queries are fairly important wrt to incrementality, which I believe has severely worsened the past 2 years, causing us to become fairly slow for (supposedly) trivial edits in documents! (one reason for this is the span map, it is not incremental friendly... we likely need to add an extra firewall query for that).

And on the topic of the word firewall query, a glossary might be nice as well :)

@Veykril Veykril added A-documentation docs for rust-analyzer usage/inner working A-salsa might be a salsa issue Broken Window Bugs / technical debt to be addressed immediately labels Jan 27, 2025
@Veykril Veykril changed the title Model the query dependeny graph Model the query dependency graph Jan 27, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-documentation docs for rust-analyzer usage/inner working A-salsa might be a salsa issue Broken Window Bugs / technical debt to be addressed immediately
Projects
None yet
Development

No branches or pull requests

1 participant