Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Generate delegate spam in code actions #19090

Open
Veykril opened this issue Feb 4, 2025 · 1 comment
Open

Generate delegate spam in code actions #19090

Veykril opened this issue Feb 4, 2025 · 1 comment
Assignees
@alibektas
Labels
A-assists A-lsp LSP conformance issues and missing features C-enhancement Category: enhancement

Comments

@Veykril
Copy link
Member

Veykril commented Feb 4, 2025

Discussed in #19087

We should disable the generate delegate code action (and similar ones that may result in spammy behavior) when the client does not support our LSP extension for grouping
@Veykril Veykril added A-assists A-lsp LSP conformance issues and missing features C-enhancement Category: enhancement labels Feb 4, 2025
@alibektas alibektas self-assigned this Feb 4, 2025
@nemethf
Copy link
Contributor

nemethf commented Feb 8, 2025

Instead of disabling the code actions when the client does not support grouping, would it be possible to create a top-level code-action with the name of the group that (when selected) sends window/showMessageRequest with all the actions of the group as MessageActionItems?

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@alibektas alibektas

Labels
A-assists A-lsp LSP conformance issues and missing features C-enhancement Category: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nemethf @Veykril @alibektas