Move arm cond to match guard #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwin0cheng
reviewed
May 16, 2019
unrealhoang
force-pushed
the
move_arm_cond_to_match_guard
branch
2 times, most recently
from
a3fa698 to
6151f0e
Compare
matklad
reviewed
May 20, 2019
|
@unrealhoang sorry for a long delay here: it's been a very busy week for me :( |
unrealhoang
force-pushed
the
move_arm_cond_to_match_guard
branch
3 times, most recently
from
8285e19 to
90392dd
Compare
unrealhoang
force-pushed
the
move_arm_cond_to_match_guard
branch
from
90392dd to
079ed60
Compare
|
bors r+ Thanks! |
Build succeeded |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did split the rename to another commit, yet Github UI still show entirely new file change. Please review using commits.