-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Can't build stylo in FF 56.x #1087
Comments
Which version of bindgen is FF56 using? |
@emilio In logs you can see |
Ping anyone ? |
Any chance you could use |
@fitzgen Sorry to say that, but i don't know rust, and all i can do is to run build in our build environement. I can provide any debug you tell me to add to .spec file when building RPM |
Still the same issue. |
That is an interesting error. @tpgxyz which version of libclang is this? Also, can you try to build nightly from https://hg.mozilla.org/mozilla-central/? That has a more up-to-date bindgen. |
@emilio I'm running LLVM 5.0.0 Well I want to compile officially released latest firefox not a nightly build, as my district's users does not want to experiment that much. |
Sure, I just wanted to know whether an updated bindgen / FF version worked in the same environment, which may be helpful. In particular, there are some bugs fixed in the way bindgen interacted with system dependencies on Firefox, like https://bugzilla.mozilla.org/show_bug.cgi?id=1341234. |
@emilio I've appiled these patches and unfortunately FF still does not build with stylo enabled. |
If you could apply this patch to the rust-bindgen tree it'd be helpful to figure that out. Alternatively, applying something like the following, and getting the diff --git a/servo/components/style/build_gecko.rs b/servo/components/style/build_gecko.rs
index 1bef36f8b289..7635f6627ef6 100644
--- a/servo/components/style/build_gecko.rs
+++ b/servo/components/style/build_gecko.rs
@@ -275,6 +275,7 @@ mod bindings {
return;
}
}
+ builder.dump_preprocessed_input().expect("Couldn't dump input");
let command_line_opts = builder.command_line_flags();
let result = builder.generate();
let mut result = match result {
@@ -565,7 +566,7 @@ mod bindings {
use std::thread;
macro_rules! run_tasks {
($($task:expr,)+) => {
- if setup_logging() {
+ if true || setup_logging() {
$($task;)+
} else {
let threads = vec![$( thread::spawn(|| $task) ),+]; |
Looks like its Float128, modifying to:
makes it build ok - i've no idea if this is correct though. attached the file requested. |
Yeah, that patch looks good to me. Want to submit a PR? Tests for this live in |
@cris-b Excellent catch. Many thanks for finding issue. |
I updated bindgen with this fix on mozilla-central in https://bugzilla.mozilla.org/show_bug.cgi?id=1432134 |
rust-lang/rust#45342
Bindgen Invocation
I'm trying to build FF 56.0.1 with rust-1.21.0.
Full logs can be found here http://file-store.openmandriva.org/api/v1/file_stores/1e85cf22a732ff76c55f52625dfab10fbfcaac23.log?show=true
error: failed to run custom build command for
style v0.0.1 (file:///builddir/build/BUILD/firefox-56.0.1/servo/components/style)
Expected Results
Firefox compiles
The text was updated successfully, but these errors were encountered: