fixup! Fix useless_attribute to also whitelist

eddyb · eddyb · commit 01545999b045 · 2018-09-15T11:15:15.000+03:00
diff --git a/tests/ui/useless_attribute.rs b/tests/ui/useless_attribute.rs
@@ -2,11 +2,12 @@
 
 #![warn(clippy::useless_attribute)]
 
-#[allow(dead_code, unused_extern_crates)]
-#[cfg_attr(feature = "cargo-clippy", allow(dead_code, unused_extern_crates))]
+#[allow(dead_code)]
+#[cfg_attr(feature = "cargo-clippy", allow(dead_code))]
 #[cfg_attr(feature = "cargo-clippy",
-           allow(dead_code, unused_extern_crates))]
+           allow(dead_code))]
 #[allow(unused_imports)]
+#[allow(unused_extern_crates)]
 #[macro_use]
 extern crate clippy_lints;
 
diff --git a/tests/ui/useless_attribute.stderr b/tests/ui/useless_attribute.stderr
@@ -1,16 +1,16 @@
 error: useless lint attribute
  --> $DIR/useless_attribute.rs:5:1
   |
-5 | #[allow(dead_code, unused_extern_crates)]
-  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code, unused_extern_crates)]`
+5 | #[allow(dead_code)]
+  | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
   |
   = note: `-D clippy::useless-attribute` implied by `-D warnings`
 
 error: useless lint attribute
  --> $DIR/useless_attribute.rs:6:1
   |
-6 | #[cfg_attr(feature = "cargo-clippy", allow(dead_code, unused_extern_crates))]
-  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code, unused_extern_crates))`
+6 | #[cfg_attr(feature = "cargo-clippy", allow(dead_code))]
+  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code))`
 
 error: aborting due to 2 previous errors
 

Original file line number	Diff line number	Diff line change
`@@ -1,16 +1,16 @@`
`1`	`1`	`error: useless lint attribute`
`2`	`2`	`--> $DIR/useless_attribute.rs:5:1`
`3`	`3`	`\|`
`4`		`-5 \| #[allow(dead_code, unused_extern_crates)]`
`5`		- \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code, unused_extern_crates)]`
	`4`	`+5 \| #[allow(dead_code)]`
	`5`	+ \| ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]`
`6`	`6`	`\|`
`7`	`7`	= note: `-D clippy::useless-attribute` implied by `-D warnings`
`8`	`8`
`9`	`9`	`error: useless lint attribute`
`10`	`10`	`--> $DIR/useless_attribute.rs:6:1`
`11`	`11`	`\|`
`12`		`-6 \| #[cfg_attr(feature = "cargo-clippy", allow(dead_code, unused_extern_crates))]`
`13`		- \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code, unused_extern_crates))`
	`12`	`+6 \| #[cfg_attr(feature = "cargo-clippy", allow(dead_code))]`
	`13`	+ \| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![cfg_attr(feature = "cargo-clippy", allow(dead_code))`
`14`	`14`
`15`	`15`	`error: aborting due to 2 previous errors`
`16`	`16`