Import declared lints at the top of the file

Author: Y-Nak

clippy_lints/src/types/borrowed_box.rs

@@ -9,6 +9,8 @@ use if_chain::if_chain;
 
 use crate::utils::{match_path, paths, snippet, span_lint_and_sugg};
 
+use super::BORROWED_BOX;
+
 pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, lt: &Lifetime, mut_ty: &MutTy<'_>) -> bool {
     match mut_ty.ty.kind {
         TyKind::Path(ref qpath) => {
@@ -61,7 +63,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, lt: &Lifetime, m
                     };
                     span_lint_and_sugg(
                         cx,
-                        super::BORROWED_BOX,
+                        BORROWED_BOX,
                         hir_ty.span,
                         "you seem to be trying to use `&Box<T>`. Consider using just `&T`",
                         "try",

clippy_lints/src/types/box_vec.rs

@@ -3,14 +3,14 @@ use rustc_lint::LateContext;
 
 use crate::utils::{paths, span_lint_and_help};
 
-use super::utils;
+use super::{utils, BOX_VEC};
 
 pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_>, def_id: DefId) -> bool {
     if Some(def_id) == cx.tcx.lang_items().owned_box() {
         if utils::match_type_parameter(cx, qpath, &paths::VEC).is_some() {
             span_lint_and_help(
                 cx,
-                super::BOX_VEC,
+                BOX_VEC,
                 hir_ty.span,
                 "you seem to be trying to use `Box<Vec<T>>`. Consider using just `Vec<T>`",
                 None,

clippy_lints/src/types/linked_list.rs

@@ -3,11 +3,13 @@ use rustc_lint::LateContext;
 
 use crate::utils::{match_def_path, paths, span_lint_and_help};
 
+use super::LINKEDLIST;
+
 pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, def_id: DefId) -> bool {
     if match_def_path(cx, def_id, &paths::LINKED_LIST) {
         span_lint_and_help(
             cx,
-            super::LINKEDLIST,
+            LINKEDLIST,
             hir_ty.span,
             "I see you're using a LinkedList! Perhaps you meant some other data structure?",
             None,

clippy_lints/src/types/option_option.rs

@@ -4,14 +4,14 @@ use rustc_span::symbol::sym;
 
 use crate::utils::{paths, span_lint};
 
-use super::utils;
+use super::{utils, OPTION_OPTION};
 
 pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_>, def_id: DefId) -> bool {
     if cx.tcx.is_diagnostic_item(sym::option_type, def_id) {
         if utils::match_type_parameter(cx, qpath, &paths::OPTION).is_some() {
             span_lint(
                 cx,
-                super::OPTION_OPTION,
+                OPTION_OPTION,
                 hir_ty.span,
                 "consider using `Option<T>` instead of `Option<Option<T>>` or a custom \
                                  enum if you need to distinguish all 3 cases",

clippy_lints/src/types/rc_buffer.rs

@@ -5,14 +5,14 @@ use rustc_span::symbol::sym;
 
 use crate::utils::{last_path_segment, paths, snippet_with_applicability, span_lint_and_sugg};
 
-use super::utils;
+use super::{utils, RC_BUFFER};
 
 pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_>, def_id: DefId) -> bool {
     if cx.tcx.is_diagnostic_item(sym::Rc, def_id) {
         if let Some(alternate) = match_buffer_type(cx, qpath) {
             span_lint_and_sugg(
                 cx,
-                super::RC_BUFFER,
+                RC_BUFFER,
                 hir_ty.span,
                 "usage of `Rc<T>` when T is a buffer type",
                 "try",
@@ -35,7 +35,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
             let mut applicability = Applicability::MachineApplicable;
             span_lint_and_sugg(
                 cx,
-                super::RC_BUFFER,
+                RC_BUFFER,
                 hir_ty.span,
                 "usage of `Rc<T>` when T is a buffer type",
                 "try",
@@ -51,7 +51,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
         if let Some(alternate) = match_buffer_type(cx, qpath) {
             span_lint_and_sugg(
                 cx,
-                super::RC_BUFFER,
+                RC_BUFFER,
                 hir_ty.span,
                 "usage of `Arc<T>` when T is a buffer type",
                 "try",
@@ -73,7 +73,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
             let mut applicability = Applicability::MachineApplicable;
             span_lint_and_sugg(
                 cx,
-                super::RC_BUFFER,
+                RC_BUFFER,
                 hir_ty.span,
                 "usage of `Arc<T>` when T is a buffer type",
                 "try",

clippy_lints/src/types/redundant_allocation.rs

@@ -5,15 +5,15 @@ use rustc_span::symbol::sym;
 
 use crate::utils::{last_path_segment, paths, snippet_with_applicability, span_lint_and_sugg};
 
-use super::utils;
+use super::{utils, REDUNDANT_ALLOCATION};
 
 pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_>, def_id: DefId) -> bool {
     if Some(def_id) == cx.tcx.lang_items().owned_box() {
         if let Some(span) = utils::match_borrows_parameter(cx, qpath) {
             let mut applicability = Applicability::MachineApplicable;
             span_lint_and_sugg(
                 cx,
-                super::REDUNDANT_ALLOCATION,
+                REDUNDANT_ALLOCATION,
                 hir_ty.span,
                 "usage of `Box<&T>`",
                 "try",
@@ -30,7 +30,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
             let mut applicability = Applicability::MachineApplicable;
             span_lint_and_sugg(
                 cx,
-                super::REDUNDANT_ALLOCATION,
+                REDUNDANT_ALLOCATION,
                 hir_ty.span,
                 "usage of `Rc<Rc<T>>`",
                 "try",
@@ -55,7 +55,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
 
             span_lint_and_sugg(
                 cx,
-                super::REDUNDANT_ALLOCATION,
+                REDUNDANT_ALLOCATION,
                 hir_ty.span,
                 "usage of `Rc<Box<T>>`",
                 "try",
@@ -70,7 +70,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
             let mut applicability = Applicability::MachineApplicable;
             span_lint_and_sugg(
                 cx,
-                super::REDUNDANT_ALLOCATION,
+                REDUNDANT_ALLOCATION,
                 hir_ty.span,
                 "usage of `Rc<&T>`",
                 "try",

clippy_lints/src/types/vec_box.rs

@@ -10,6 +10,8 @@ use if_chain::if_chain;
 
 use crate::utils::{last_path_segment, snippet, span_lint_and_sugg};
 
+use super::VEC_BOX;
+
 pub(super) fn check(
     cx: &LateContext<'_>,
     hir_ty: &hir::Ty<'_>,
@@ -44,7 +46,7 @@ pub(super) fn check(
             then {
                 span_lint_and_sugg(
                     cx,
-                    super::VEC_BOX,
+                    VEC_BOX,
                     hir_ty.span,
                     "`Vec<T>` is already on the heap, the boxing is unnecessary.",
                     "try",