Skip to content

[build] clippy doesn't run in some integration tests #4719

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
tesuji opened this issue Oct 23, 2019 · 4 comments
Closed

[build] clippy doesn't run in some integration tests #4719

tesuji opened this issue Oct 23, 2019 · 4 comments
Labels
A-infra Area: CI issues and issues that require full access for GitHub/CI

Comments

@tesuji
Copy link
Contributor

tesuji commented Oct 23, 2019

Some integration tests use virtual workspace will not be tested by clippy:

Error from integration test of future-rs:

$ cargo clippy --all-targets --all-features -- --cap-lints warn -W clippy::pedantic -W clippy::nursery
error: --all-features is not allowed in the root of a virtual workspace

What should we do with it?

  1. Drop the --all-features flag?
  2. Specify a MANIFEST_PATH env for each crate has virtual workspace and pass it to each cargo clippy invocation?
@tesuji
Copy link
Contributor Author

tesuji commented Oct 23, 2019

Seems like the issue was resolved in cargo: rust-lang/cargo#7525
Wait for the rust PR to merge: rust-lang/rust#65710

@phansch
Copy link
Member

phansch commented Oct 24, 2019

Regardless of the cargo PR, we should make sure the integration tests fail if something like that happens.

@flip1995 flip1995 added the A-infra Area: CI issues and issues that require full access for GitHub/CI label Oct 24, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Oct 24, 2019

How do we check if similar issues happen?

@tesuji
Copy link
Contributor Author

tesuji commented Oct 26, 2019

rust-lang/rust#65710 merged. Closing this issue.

@tesuji tesuji closed this as completed Oct 26, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-infra Area: CI issues and issues that require full access for GitHub/CI
Projects
None yet
Development

No branches or pull requests

3 participants