Skip to content

Commit 5531c31

Browse files
authored
Auto merge of #36354 - mikhail-m1:master, r=jonathandturner
fix span for errors E0537, E0535 & E0536 fix #36182 as part of #35233
2 parents f81f496 + fb85dd3 commit 5531c31

File tree

7 files changed

+29
-5
lines changed

7 files changed

+29
-5
lines changed

src/libsyntax/parse/attr.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ impl<'a> Parser<'a> {
125125

126126
self.expect(&token::OpenDelim(token::Bracket))?;
127127
let meta_item = self.parse_meta_item()?;
128-
let hi = self.span.hi;
128+
let hi = self.last_span.hi;
129129
self.expect(&token::CloseDelim(token::Bracket))?;
130130

131131
(mk_sp(lo, hi), meta_item, style)
@@ -231,12 +231,12 @@ impl<'a> Parser<'a> {
231231
token::Eq => {
232232
self.bump();
233233
let lit = self.parse_unsuffixed_lit()?;
234-
let hi = self.span.hi;
234+
let hi = self.last_span.hi;
235235
Ok(P(spanned(lo, hi, ast::MetaItemKind::NameValue(name, lit))))
236236
}
237237
token::OpenDelim(token::Paren) => {
238238
let inner_items = self.parse_meta_seq()?;
239-
let hi = self.span.hi;
239+
let hi = self.last_span.hi;
240240
Ok(P(spanned(lo, hi, ast::MetaItemKind::List(name, inner_items))))
241241
}
242242
_ => {
@@ -253,14 +253,14 @@ impl<'a> Parser<'a> {
253253

254254
match self.parse_unsuffixed_lit() {
255255
Ok(lit) => {
256-
return Ok(spanned(lo, self.span.hi, ast::NestedMetaItemKind::Literal(lit)))
256+
return Ok(spanned(lo, self.last_span.hi, ast::NestedMetaItemKind::Literal(lit)))
257257
}
258258
Err(ref mut err) => self.diagnostic().cancel(err)
259259
}
260260

261261
match self.parse_meta_item() {
262262
Ok(mi) => {
263-
return Ok(spanned(lo, self.span.hi, ast::NestedMetaItemKind::MetaItem(mi)))
263+
return Ok(spanned(lo, self.last_span.hi, ast::NestedMetaItemKind::MetaItem(mi)))
264264
}
265265
Err(ref mut err) => self.diagnostic().cancel(err)
266266
}
File renamed without changes.

src/test/ui/span/E0535.stderr

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
error[E0535]: invalid argument
2+
--> $DIR/E0535.rs:11:10
3+
|
4+
11 | #[inline(unknown)] //~ ERROR E0535
5+
| ^^^^^^^
6+
7+
error: aborting due to previous error
8+
File renamed without changes.

src/test/ui/span/E0536.stderr

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
error[E0536]: expected 1 cfg-pattern
2+
--> $DIR/E0536.rs:11:7
3+
|
4+
11 | #[cfg(not())] //~ ERROR E0536
5+
| ^^^^^
6+
7+
error: aborting due to previous error
8+
File renamed without changes.

src/test/ui/span/E0537.stderr

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
error[E0537]: invalid predicate `unknown`
2+
--> $DIR/E0537.rs:11:7
3+
|
4+
11 | #[cfg(unknown())] //~ ERROR E0537
5+
| ^^^^^^^^^
6+
7+
error: aborting due to previous error
8+

0 commit comments

Comments
 (0)