PR feedback

Author: scottmcm

Diff for: compiler/rustc_codegen_llvm/src/builder.rs

@@ -902,7 +902,7 @@ impl<'a, 'll, 'tcx> BuilderMethods<'a, 'tcx> for Builder<'a, 'll, 'tcx> {
         let trunc = self.trunc(val, dest_ty);
         if llvm_util::get_version() >= (19, 0, 0) {
             unsafe {
-                if llvm::LLVMIsATruncInst(trunc).is_some() {
+                if llvm::LLVMIsAInstruction(trunc).is_some() {
                     llvm::LLVMSetNUW(trunc, True);
                 }
             }
@@ -914,7 +914,7 @@ impl<'a, 'll, 'tcx> BuilderMethods<'a, 'tcx> for Builder<'a, 'll, 'tcx> {
         let trunc = self.trunc(val, dest_ty);
         if llvm_util::get_version() >= (19, 0, 0) {
             unsafe {
-                if llvm::LLVMIsATruncInst(trunc).is_some() {
+                if llvm::LLVMIsAInstruction(trunc).is_some() {
                     llvm::LLVMSetNSW(trunc, True);
                 }
             }

Diff for: compiler/rustc_codegen_llvm/src/llvm/ffi.rs

@@ -1165,7 +1165,6 @@ unsafe extern "C" {
 
     // Operations on instructions
     pub(crate) fn LLVMIsAInstruction(Val: &Value) -> Option<&Value>;
-    pub(crate) fn LLVMIsATruncInst(Val: &Value) -> Option<&Value>;
     pub(crate) fn LLVMGetFirstBasicBlock(Fn: &Value) -> &BasicBlock;
     pub(crate) fn LLVMGetOperand(Val: &Value, Index: c_uint) -> Option<&Value>;
 

Diff for: tests/codegen/unchecked_shifts.rs

@@ -24,9 +24,9 @@ pub unsafe fn unchecked_shl_unsigned_same(a: u32, b: u32) -> u32 {
 #[no_mangle]
 pub unsafe fn unchecked_shl_unsigned_smaller(a: u16, b: u32) -> u16 {
     // CHECK-NOT: assume
-    // LLVM18-DAG: %[[TRUNC:.+]] = trunc i32 %b to i16
-    // LLVM19PLUS-DAG: %[[TRUNC:.+]] = trunc nuw i32 %b to i16
-    // CHECK-DAG: shl i16 %a, %[[TRUNC]]
+    // LLVM18: %[[TRUNC:.+]] = trunc i32 %b to i16
+    // LLVM19PLUS: %[[TRUNC:.+]] = trunc nuw i32 %b to i16
+    // CHECK: shl i16 %a, %[[TRUNC]]
     a.unchecked_shl(b)
 }