Skip to content

Commit 93295ff

Browse files
Remove some unnecessary TODOs
1 parent 4609841 commit 93295ff

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

Diff for: compiler/rustc_interface/src/passes.rs

-2
Original file line numberDiff line numberDiff line change
@@ -796,8 +796,6 @@ fn run_required_analyses(tcx: TyCtxt<'_>) {
796796
// Freeze definitions as we don't add new ones at this point.
797797
// We need to wait until now since we synthesize a by-move body
798798
// This improves performance by allowing lock-free access to them.
799-
// FIXME(async_closures): We could force `coroutine_by_move_body_def_id`
800-
// immediately after typeck, then freeze after that.
801799
tcx.untracked().definitions.freeze();
802800

803801
sess.time("MIR_borrow_checking", || {

Diff for: compiler/rustc_metadata/src/rmeta/encoder.rs

-5
Original file line numberDiff line numberDiff line change
@@ -1066,7 +1066,6 @@ fn should_encode_mir(
10661066
}
10671067
// Coroutines require optimized MIR to compute layout.
10681068
DefKind::Closure if tcx.is_coroutine(def_id.to_def_id()) => (false, true),
1069-
// FIXME: lol
10701069
DefKind::SyntheticCoroutineBody => (false, true),
10711070
// Full-fledged functions + closures
10721071
DefKind::AssocFn | DefKind::Fn | DefKind::Closure => {
@@ -1379,10 +1378,6 @@ impl<'a, 'tcx> EncodeContext<'a, 'tcx> {
13791378
let def_span = tcx.def_span(local_id);
13801379
record!(self.tables.def_span[def_id] <- def_span);
13811380
}
1382-
// FIXME(async_closures): We should just use `tcx.attrs` rather than going
1383-
// through the HIR. Historically, though, this has been inefficient apparently.
1384-
// For now, it's kind of pointless to fix, because coroutine-closures' coroutine
1385-
// bodies have no attrs anyways.
13861381
if should_encode_attrs(def_kind) {
13871382
self.encode_attrs(local_id);
13881383
}

0 commit comments

Comments
 (0)