Add FIXME for tcx.hir() returned type about its removal

zetanumbers · zetanumbers · commit 9509ff4d8089 · 2023-12-12T06:04:06.000-08:00
diff --git a/compiler/rustc_middle/src/hir/map/mod.rs b/compiler/rustc_middle/src/hir/map/mod.rs
@@ -57,6 +57,10 @@ fn is_body_owner(node: Node<'_>, hir_id: HirId) -> bool {
     }
 }
 
+// FIXME: the structure was necessary in the past but now it
+// only serves as "namespace" for HIR-related methods, and can be
+// removed if all the methods are reasonably renamed and moved to tcx
+// (https://github.com/rust-lang/rust/pull/118256#issuecomment-1826442834).
 #[derive(Copy, Clone)]
 pub struct Map<'hir> {
     pub(super) tcx: TyCtxt<'hir>,

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,10 @@ fn is_body_owner(node: Node<'_>, hir_id: HirId) -> bool {`
`57`	`57`	`}`
`58`	`58`	`}`
`59`	`59`
	`60`	`+// FIXME: the structure was necessary in the past but now it`
	`61`	`+// only serves as "namespace" for HIR-related methods, and can be`
	`62`	`+// removed if all the methods are reasonably renamed and moved to tcx`
	`63`	`+// (https://github.com/rust-lang/rust/pull/118256#issuecomment-1826442834).`
`60`	`64`	`#[derive(Copy, Clone)]`
`61`	`65`	`pub struct Map<'hir> {`
`62`	`66`	`pub(super) tcx: TyCtxt<'hir>,`