Skip to content

Commit a9a7da7

Browse files
Dylan-DPCDylan-DPC
authored
Rollup merge of #68929 - matprec:consistent-issue-references, r=Dylan-DPC
Make issue references consistent Fixes #62976 cc #63008 r? @varkor because you reviewed the original pr
2 parents 2bd0dbd + 2875a0c commit a9a7da7

File tree

263 files changed

+772
-729
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

263 files changed

+772
-729
lines changed

Diff for: ‎src/librustc/traits/error_reporting/mod.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -700,11 +700,11 @@ impl<'a, 'tcx> InferCtxt<'a, 'tcx> {
700700
if self.predicate_may_hold(&unit_obligation) {
701701
err.note(
702702
"the trait is implemented for `()`. \
703-
Possibly this error has been caused by changes to \
704-
Rust's type-inference algorithm \
705-
(see: https://github.com/rust-lang/rust/issues/48950 \
706-
for more info). Consider whether you meant to use the \
707-
type `()` here instead.",
703+
Possibly this error has been caused by changes to \
704+
Rust's type-inference algorithm (see issue #48950 \
705+
<https://github.com/rust-lang/rust/issues/48950> \
706+
for more information). Consider whether you meant to use \
707+
the type `()` here instead.",
708708
);
709709
}
710710
}

Diff for: ‎src/librustc/traits/error_reporting/suggestions.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1508,9 +1508,9 @@ impl<'a, 'tcx> InferCtxt<'a, 'tcx> {
15081508
);
15091509
if suggest_const_in_array_repeat_expressions {
15101510
err.note(
1511-
"this array initializer can be evaluated at compile-time, for more \
1512-
information, see issue \
1513-
https://github.com/rust-lang/rust/issues/49147",
1511+
"this array initializer can be evaluated at compile-time, see issue \
1512+
#48147 <https://github.com/rust-lang/rust/issues/49147> \
1513+
for more information",
15141514
);
15151515
if tcx.sess.opts.unstable_features.is_nightly_build() {
15161516
err.help(

Diff for: ‎src/librustc/ty/error.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -483,8 +483,9 @@ impl Trait for X {
483483
if ty.is_closure() || ty.is_generator() {
484484
db.note(
485485
"closures cannot capture themselves or take themselves as argument;\n\
486-
this error may be the result of a recent compiler bug-fix,\n\
487-
see https://github.com/rust-lang/rust/issues/46062 for more details",
486+
this error may be the result of a recent compiler bug-fix,\n\
487+
see issue #46062 <https://github.com/rust-lang/rust/issues/46062>\n\
488+
for more information",
488489
);
489490
}
490491
}

Diff for: ‎src/librustc_ast_passes/ast_validation.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -996,7 +996,8 @@ impl<'a> Visitor<'a> for AstValidator<'a> {
996996
)
997997
.span_label(predicate.span, "not supported")
998998
.note(
999-
"for more information, see https://github.com/rust-lang/rust/issues/20041",
999+
"see issue #20041 <https://github.com/rust-lang/rust/issues/20041> \
1000+
for more information",
10001001
)
10011002
.emit();
10021003
}

Diff for: ‎src/librustc_lint/lib.rs

+38-19
Original file line numberDiff line numberDiff line change
@@ -324,47 +324,58 @@ fn register_builtins(store: &mut LintStore, no_interleave_lints: bool) {
324324
);
325325
store.register_removed(
326326
"hr_lifetime_in_assoc_type",
327-
"converted into hard error, see https://github.com/rust-lang/rust/issues/33685",
327+
"converted into hard error, see issue #33685 \
328+
<https://github.com/rust-lang/rust/issues/33685> for more information",
328329
);
329330
store.register_removed(
330331
"inaccessible_extern_crate",
331-
"converted into hard error, see https://github.com/rust-lang/rust/issues/36886",
332+
"converted into hard error, see issue #36886 \
333+
<https://github.com/rust-lang/rust/issues/36886> for more information",
332334
);
333335
store.register_removed(
334336
"super_or_self_in_global_path",
335-
"converted into hard error, see https://github.com/rust-lang/rust/issues/36888",
337+
"converted into hard error, see issue #36888 \
338+
<https://github.com/rust-lang/rust/issues/36888> for more information",
336339
);
337340
store.register_removed(
338341
"overlapping_inherent_impls",
339-
"converted into hard error, see https://github.com/rust-lang/rust/issues/36889",
342+
"converted into hard error, see issue #36889 \
343+
<https://github.com/rust-lang/rust/issues/36889> for more information",
340344
);
341345
store.register_removed(
342346
"illegal_floating_point_constant_pattern",
343-
"converted into hard error, see https://github.com/rust-lang/rust/issues/36890",
347+
"converted into hard error, see issue #36890 \
348+
<https://github.com/rust-lang/rust/issues/36890> for more information",
344349
);
345350
store.register_removed(
346351
"illegal_struct_or_enum_constant_pattern",
347-
"converted into hard error, see https://github.com/rust-lang/rust/issues/36891",
352+
"converted into hard error, see issue #36891 \
353+
<https://github.com/rust-lang/rust/issues/36891> for more information",
348354
);
349355
store.register_removed(
350356
"lifetime_underscore",
351-
"converted into hard error, see https://github.com/rust-lang/rust/issues/36892",
357+
"converted into hard error, see issue #36892 \
358+
<https://github.com/rust-lang/rust/issues/36892> for more information",
352359
);
353360
store.register_removed(
354361
"extra_requirement_in_impl",
355-
"converted into hard error, see https://github.com/rust-lang/rust/issues/37166",
362+
"converted into hard error, see issue #37166 \
363+
<https://github.com/rust-lang/rust/issues/37166> for more information",
356364
);
357365
store.register_removed(
358366
"legacy_imports",
359-
"converted into hard error, see https://github.com/rust-lang/rust/issues/38260",
367+
"converted into hard error, see issue #38260 \
368+
<https://github.com/rust-lang/rust/issues/38260> for more information",
360369
);
361370
store.register_removed(
362371
"coerce_never",
363-
"converted into hard error, see https://github.com/rust-lang/rust/issues/48950",
372+
"converted into hard error, see issue #48950 \
373+
<https://github.com/rust-lang/rust/issues/48950> for more information",
364374
);
365375
store.register_removed(
366376
"resolve_trait_on_defaulted_unit",
367-
"converted into hard error, see https://github.com/rust-lang/rust/issues/48950",
377+
"converted into hard error, see issue #48950 \
378+
<https://github.com/rust-lang/rust/issues/48950> for more information",
368379
);
369380
store.register_removed(
370381
"private_no_mangle_fns",
@@ -377,35 +388,43 @@ fn register_builtins(store: &mut LintStore, no_interleave_lints: bool) {
377388
store.register_removed("bad_repr", "replaced with a generic attribute input check");
378389
store.register_removed(
379390
"duplicate_matcher_binding_name",
380-
"converted into hard error, see https://github.com/rust-lang/rust/issues/57742",
391+
"converted into hard error, see issue #57742 \
392+
<https://github.com/rust-lang/rust/issues/57742> for more information",
381393
);
382394
store.register_removed(
383395
"incoherent_fundamental_impls",
384-
"converted into hard error, see https://github.com/rust-lang/rust/issues/46205",
396+
"converted into hard error, see issue #46205 \
397+
<https://github.com/rust-lang/rust/issues/46205> for more information",
385398
);
386399
store.register_removed(
387400
"legacy_constructor_visibility",
388-
"converted into hard error, see https://github.com/rust-lang/rust/issues/39207",
401+
"converted into hard error, see issue #39207 \
402+
<https://github.com/rust-lang/rust/issues/39207> for more information",
389403
);
390404
store.register_removed(
391405
"legacy_directory_ownership",
392-
"converted into hard error, see https://github.com/rust-lang/rust/issues/37872",
406+
"converted into hard error, see issue #37872 \
407+
<https://github.com/rust-lang/rust/issues/37872> for more information",
393408
);
394409
store.register_removed(
395410
"safe_extern_statics",
396-
"converted into hard error, see https://github.com/rust-lang/rust/issues/36247",
411+
"converted into hard error, see issue #36247 \
412+
<https://github.com/rust-lang/rust/issues/36247> for more information",
397413
);
398414
store.register_removed(
399415
"parenthesized_params_in_types_and_modules",
400-
"converted into hard error, see https://github.com/rust-lang/rust/issues/42238",
416+
"converted into hard error, see issue #42238 \
417+
<https://github.com/rust-lang/rust/issues/42238> for more information",
401418
);
402419
store.register_removed(
403420
"duplicate_macro_exports",
404-
"converted into hard error, see https://github.com/rust-lang/rust/issues/35896",
421+
"converted into hard error, see issue #35896 \
422+
<https://github.com/rust-lang/rust/issues/35896> for more information",
405423
);
406424
store.register_removed(
407425
"nested_impl_trait",
408-
"converted into hard error, see https://github.com/rust-lang/rust/issues/59014",
426+
"converted into hard error, see issue #59014 \
427+
<https://github.com/rust-lang/rust/issues/59014> for more information",
409428
);
410429
store.register_removed("plugin_as_library", "plugins have been deprecated and retired");
411430
}

Diff for: ‎src/librustc_mir/transform/check_consts/validation.rs

+7-4
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,10 @@ impl Visitor<'tcx> for Validator<'_, 'mir, 'tcx> {
565565

566566
fn error_min_const_fn_violation(tcx: TyCtxt<'_>, span: Span, msg: Cow<'_, str>) {
567567
struct_span_err!(tcx.sess, span, E0723, "{}", msg)
568-
.note("for more information, see issue https://github.com/rust-lang/rust/issues/57563")
568+
.note(
569+
"see issue #57563 <https://github.com/rust-lang/rust/issues/57563> \
570+
for more information",
571+
)
569572
.help("add `#![feature(const_fn)]` to the crate attributes to enable")
570573
.emit();
571574
}
@@ -593,9 +596,9 @@ fn check_short_circuiting_in_const_local(item: &Item<'_, 'tcx>) {
593596
*span,
594597
&format!(
595598
"use of {} here does not actually short circuit due to \
596-
the const evaluator presently not being able to do control flow. \
597-
See https://github.com/rust-lang/rust/issues/49146 for more \
598-
information.",
599+
the const evaluator presently not being able to do control flow. \
600+
See issue #49146 <https://github.com/rust-lang/rust/issues/49146> \
601+
for more information.",
599602
kind
600603
),
601604
);

Diff for: ‎src/librustc_parse/lexer/mod.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -248,8 +248,9 @@ impl<'a> StringReader<'a> {
248248
a future release!",
249249
)
250250
.note(
251-
"for more information, see issue #42326 \
252-
<https://github.com/rust-lang/rust/issues/42326>",
251+
"see issue #42326 \
252+
<https://github.com/rust-lang/rust/issues/42326> \
253+
for more information",
253254
)
254255
.emit();
255256
None

Diff for: ‎src/librustc_parse/parser/diagnostics.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -366,8 +366,8 @@ impl<'a> Parser<'a> {
366366
type: `<expr>: <type>`",
367367
);
368368
err.note(
369-
"for more information, see \
370-
https://github.com/rust-lang/rust/issues/23416",
369+
"see issue #23416 <https://github.com/rust-lang/rust/issues/23416> \
370+
for more information",
371371
);
372372
}
373373
}

Diff for: ‎src/librustc_parse/parser/expr.rs

+4-1
Original file line numberDiff line numberDiff line change
@@ -1295,7 +1295,10 @@ impl<'a> Parser<'a> {
12951295
`proc_macro::Literal::*_unsuffixed` for code that will desugar \
12961296
to tuple field access",
12971297
);
1298-
err.note("for more context, see https://github.com/rust-lang/rust/issues/60210");
1298+
err.note(
1299+
"see issue #60210 <https://github.com/rust-lang/rust/issues/60210> \
1300+
for more information",
1301+
);
12991302
err
13001303
} else {
13011304
self.struct_span_err(sp, &format!("suffixes on {} are invalid", kind))

Diff for: ‎src/librustc_passes/check_attr.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ impl CheckAttrVisitor<'tcx> {
120120
a future release!",
121121
)
122122
.note(
123-
"for more information, see issue #65833 \
124-
<https://github.com/rust-lang/rust/issues/65833>",
123+
"see issue #65833 <https://github.com/rust-lang/rust/issues/65833> \
124+
for more information",
125125
)
126126
.emit();
127127
true

Diff for: ‎src/librustc_session/parse.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ pub fn feature_err_issue<'a>(
8686

8787
if let Some(n) = find_feature_issue(feature, issue) {
8888
err.note(&format!(
89-
"for more information, see https://github.com/rust-lang/rust/issues/{}",
90-
n,
89+
"see issue #{} <https://github.com/rust-lang/rust/issues/{}> for more information",
90+
n, n,
9191
));
9292
}
9393

Diff for: ‎src/librustc_session/session.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -1125,7 +1125,8 @@ fn validate_commandline_args_with_session_available(sess: &Session) {
11251125
sess.err(
11261126
"Profile-guided optimization does not yet work in conjunction \
11271127
with `-Cpanic=unwind` on Windows when targeting MSVC. \
1128-
See https://github.com/rust-lang/rust/issues/61002 for details.",
1128+
See issue #61002 <https://github.com/rust-lang/rust/issues/61002> \
1129+
for more information.",
11291130
);
11301131
}
11311132

Diff for: ‎src/librustc_typeck/check/demand.rs

+4-3
Original file line numberDiff line numberDiff line change
@@ -797,9 +797,10 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
797797
);
798798
err.warn(
799799
"if the rounded value cannot be represented by the target \
800-
integer type, including `Inf` and `NaN`, casting will cause \
801-
undefined behavior \
802-
(https://github.com/rust-lang/rust/issues/10184)",
800+
integer type, including `Inf` and `NaN`, casting will cause \
801+
undefined behavior \
802+
(see issue #10184 <https://github.com/rust-lang/rust/issues/10184> \
803+
for more information)",
803804
);
804805
}
805806
true

Diff for: ‎src/librustc_typeck/collect.rs

+4-1
Original file line numberDiff line numberDiff line change
@@ -2439,7 +2439,10 @@ fn associated_item_predicates(
24392439
trait_item.span,
24402440
&format!("{}-generic associated types are not yet implemented", arg_kind),
24412441
)
2442-
.note("for more information, see https://github.com/rust-lang/rust/issues/44265")
2442+
.note(
2443+
"for more information, see issue #44265 \
2444+
<https://github.com/rust-lang/rust/issues/44265> for more information",
2445+
)
24432446
.emit();
24442447
had_error = true;
24452448
}

Diff for: ‎src/librustdoc/config.rs

+4-1
Original file line numberDiff line numberDiff line change
@@ -570,7 +570,10 @@ fn check_deprecated_options(matches: &getopts::Matches, diag: &rustc_errors::Han
570570
if matches.opt_present(flag) {
571571
let mut err =
572572
diag.struct_warn(&format!("the '{}' flag is considered deprecated", flag));
573-
err.warn("please see https://github.com/rust-lang/rust/issues/44136");
573+
err.warn(
574+
"see issue #44136 <https://github.com/rust-lang/rust/issues/44136> \
575+
for more information",
576+
);
574577

575578
if *flag == "no-defaults" {
576579
err.help("you may want to use --document-private-items");

Diff for: ‎src/librustdoc/core.rs

+4-1
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,10 @@ pub fn run_core(options: RustdocOptions) -> (clean::Crate, RenderInfo, RenderOpt
416416
considered deprecated",
417417
name
418418
));
419-
msg.warn("please see https://github.com/rust-lang/rust/issues/44136");
419+
msg.warn(
420+
"see issue #44136 <https://github.com/rust-lang/rust/issues/44136> \
421+
for more information",
422+
);
420423

421424
if name == "no_default_passes" {
422425
msg.help("you may want to use `#![doc(document_private_items)]`");

Diff for: ‎src/test/rustdoc-ui/deprecated-attrs.stderr

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
warning: the `#![doc(no_default_passes)]` attribute is considered deprecated
22
|
3-
= warning: please see https://github.com/rust-lang/rust/issues/44136
3+
= warning: see issue #44136 <https://github.com/rust-lang/rust/issues/44136> for more information
44
= help: you may want to use `#![doc(document_private_items)]`
55

66
warning: the `#![doc(passes = "...")]` attribute is considered deprecated
77
|
8-
= warning: please see https://github.com/rust-lang/rust/issues/44136
8+
= warning: see issue #44136 <https://github.com/rust-lang/rust/issues/44136> for more information
99

Diff for: ‎src/test/ui-fulldeps/feature-gate-plugin.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ error[E0658]: compiler plugins are deprecated
44
LL | #![plugin(empty_plugin)]
55
| ^^^^^^^^^^^^^^^^^^^^^^^^
66
|
7-
= note: for more information, see https://github.com/rust-lang/rust/issues/29597
7+
= note: see issue #29597 <https://github.com/rust-lang/rust/issues/29597> for more information
88
= help: add `#![feature(plugin)]` to the crate attributes to enable
99

1010
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675

Diff for: ‎src/test/ui-fulldeps/gated-plugin.stderr

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ error[E0658]: compiler plugins are deprecated
44
LL | #![plugin(empty_plugin)]
55
| ^^^^^^^^^^^^^^^^^^^^^^^^
66
|
7-
= note: for more information, see https://github.com/rust-lang/rust/issues/29597
7+
= note: see issue #29597 <https://github.com/rust-lang/rust/issues/29597> for more information
88
= help: add `#![feature(plugin)]` to the crate attributes to enable
99

1010
warning: use of deprecated attribute `plugin`: compiler plugins are deprecated. See https://github.com/rust-lang/rust/pull/64675

0 commit comments

Comments
 (0)