Skip to content

Sidebar links for methods from Deref are wrong if the type has a method of the same name #100679

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jplatte opened this issue Aug 17, 2022 · 0 comments · Fixed by #100731
Closed
Assignees
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jplatte
Copy link
Contributor

jplatte commented Aug 17, 2022

On https://doc.rust-lang.org/nightly/std/vec/struct.Vec.html, there's two is_empty methods, one from Vec (why does Vec even have its own rather than relying on the slice one?? 😅) and one from [T] which Vec deref's to:

The link is_empty in the sidebar section "Methods from Deref<Target = [T]>" however doesn't link to the latter, it links to the former.

@rustbot labels: +T-rustdoc +A-rustdoc-ui

@jplatte jplatte added the C-bug Category: This is a bug. label Aug 17, 2022
@rustbot rustbot added A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 17, 2022
@notriddle notriddle self-assigned this Aug 18, 2022
@bors bors closed this as completed in ecd2885 Aug 19, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants