Skip to content

Bootstrap should support build directories within an unrelated git repository #102562

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jyn514 opened this issue Oct 2, 2022 · 0 comments · Fixed by #102581
Closed

Bootstrap should support build directories within an unrelated git repository #102562

jyn514 opened this issue Oct 2, 2022 · 0 comments · Fixed by #102581
Labels
C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Milestone
1.66.0

Comments

@jyn514
Copy link
Member

jyn514 commented Oct 2, 2022

#98483 recently broke the case where the source directory is built from a git clone, but the build directory is inside a different, unrelated git clone. Bootstrap shouldn't have opinions on where the build directory is; we should fix it.

We can detect this case by seeing if config.src.join("src").join("stage0.json") is present; if not, we guessed the source directory incorrectly and we should fallback to the old logic using CARGO_MANIFEST_DIR.

Originally posted by @cr1901 in #98483 (comment)
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Oct 2, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 2, 2022
@jyn514 jyn514 added this to the 1.66.0 milestone Oct 2, 2022
@jyn514 jyn514 mentioned this issue Oct 3, 2022
Merged
@apiraino apiraino added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Oct 6, 2022
@bors bors closed this as completed in 5d2c29d Oct 9, 2022
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 16, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging a pull request may close this issue.

Make the config.src handling for downloadable bootstrap more conservative jyn514/rust
3 participants
@apiraino @jyn514 @rustbot