Skip to content

Need to add a test for marker traits with 'static #103574

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jackh726 opened this issue Oct 26, 2022 · 6 comments · Fixed by #103611
Closed

Need to add a test for marker traits with 'static #103574

jackh726 opened this issue Oct 26, 2022 · 6 comments · Fixed by #103611
Assignees
Labels
E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. F-marker_trait_attr `#![feature(marker_trait_attr)]`

Comments

@jackh726
Copy link
Member

jackh726 commented Oct 26, 2022

Not sure if we have a test for the following

#![feature(marker_trait_attr)]
#[marker] trait Marker {}
impl Marker for &'static () {}
impl Marker for &'static () {}

and

```rust
#![feature(marker_trait_attr)]
#[marker] trait Marker {}
impl Marker for &'_ () {}
impl Marker for &'_ () {}

If not, we need to add them, since they would be important for special casing 'static during canonicalization.

@jackh726 jackh726 added the E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. label Oct 26, 2022
@Rageking8
Copy link
Contributor

I can help add this test if needed. (Did not rustbot claim so as to not remove lcnr from assignee)

@jackh726
Copy link
Member Author

Sure :) would help out @lcnr if nothing else

@lcnr

This comment was marked as outdated.

@rustbot

This comment was marked as outdated.

@lcnr
Copy link
Contributor

lcnr commented Oct 27, 2022

@rustbot assign @Rageking8

@rustbot rustbot assigned Rageking8 and unassigned lcnr Oct 27, 2022
@Rageking8
Copy link
Contributor

@rustbot label +F-marker_trait_attr

In case this needs to be indexed in the future.

@rustbot rustbot added the F-marker_trait_attr `#![feature(marker_trait_attr)]` label Oct 27, 2022
@bors bors closed this as completed in 2252f7a Oct 27, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. F-marker_trait_attr `#![feature(marker_trait_attr)]`
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants