Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

pre-push git hooks should avoid push remote when test tidy --bless failed #104718

Closed
chenyukang opened this issue Nov 22, 2022 · 4 comments
Closed
Assignees

Comments

@chenyukang
Copy link
Member

chenyukang commented Nov 22, 2022

I met this issue several times, after I pushed code to remote PR, the CI failed because test tidy --bless failed.
https://github.com/rust-lang/rust/actions/runs/3524341026/jobs/5909613972

I have an investigation, we have a pre-push git hook setup, but seems we do not exit when test tidy --bless changed code format, and push will also successfully, then the CI will fail for this issue.

$COMMAND

I think we should keep consistent here, if there are code format issues, git push will fail until it's fixed.

A inconvenience with this is some developers may want to push frequently with temporary changes.

@jyn514

@jyn514
Copy link
Member

jyn514 commented Nov 22, 2022

Sounds good :) are you interested in making a PR?

@chenyukang
Copy link
Member Author

Ok, will give it a try.

@chenyukang
Copy link
Member Author

@rustbot claim

@chenyukang
Copy link
Member Author

chenyukang commented Nov 24, 2022

This issue is fixed by #101175,
But my local .git/hooks/pre-push haven't updated.

Closing the issue now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants