You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have an investigation, we have a pre-push git hook setup, but seems we do not exit when test tidy --bless changed code format, and push will also successfully, then the CI will fail for this issue.
I met this issue several times, after I pushed code to remote PR, the CI failed because
test tidy --bless
failed.https://github.com/rust-lang/rust/actions/runs/3524341026/jobs/5909613972
I have an investigation, we have a
pre-push
git hook setup, but seems we do not exit whentest tidy --bless
changed code format, and push will also successfully, then the CI will fail for this issue.rust/src/etc/pre-push.sh
Line 25 in b7463e8
I think we should keep consistent here, if there are code format issues,
git push
will fail until it's fixed.A inconvenience with this is some developers may want to push frequently with temporary changes.
@jyn514
The text was updated successfully, but these errors were encountered: