Skip to content

x dist --stage 0 does not check out submodules automatically #108111

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
KittyBorgX opened this issue Feb 16, 2023 · 3 comments
Closed

x dist --stage 0 does not check out submodules automatically #108111

KittyBorgX opened this issue Feb 16, 2023 · 3 comments
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@KittyBorgX
Copy link
Member

KittyBorgX commented Feb 16, 2023 •
edited by rustbot
Loading

I'm working on : #107956 and got x dist --stage 0 past all errors and hit into this roadblock.
x dist --stage 0 build successfully when I run git submodule update --init:
image

Expected behavior : running x dist --stage 0 should check out submodules automatically
@KittyBorgX KittyBorgX added the C-bug Category: This is a bug. label Feb 16, 2023
@KittyBorgX KittyBorgX mentioned this issue Feb 16, 2023
Merged
@zephaniahong
Copy link
Contributor

@rustbot claim

@jyn514 jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Feb 16, 2023
@zephaniahong
Copy link
Contributor

@KittyBorgX Hi! Am I right to say that I have to wait for you PR to merge before I can work on this? Reason being, I am unable to run x dist --stage 0 without getting an error.

@KittyBorgX
Copy link
Member Author

@KittyBorgX Hi! Am I right to say that I have to wait for you PR to merge before I can work on this? Reason being, I am unable to run x dist --stage 0 without getting an error.

Yupp. The other errors in x dist --stage 0 should be fixed in my PR. The PR is ready, I believe. It's awaiting a rollup/merge now.

@zephaniahong zephaniahong mentioned this issue Feb 18, 2023
Closed
@zephaniahong zephaniahong removed their assignment Jun 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jyn514 @zephaniahong @onur-ozkan @KittyBorgX